feat(helm): add snapshot functionality with automatic cleanup #5892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add snapshot configuration section to values.yaml with: - Enable/disable toggle - Cron schedule configuration - Format selection (dragonfly/rdb) - Cleaner settings (image, interval, max count, resources) - Add snapshot-cleaner sidecar container to pod template: - Automatically removes old snapshots based on max_count - Supports both dragonfly (.dfs) and rdb formats - Configurable cleanup interval and resource limits - Add snapshot cron arguments to main dragonfly container - Maintains backward compatibility with existing configurations
renan
force-pushed
the
snapshot-cleaner
branch
from
55c2fe3 to
493d357
Compare
Abhra303
reviewed
Nov 18, 2025
| - -c | ||
| - | | ||
| while true; do | ||
| {{- if eq .Values.snapshot.format "dragonfly" }} |
Contributor
There was a problem hiding this comment.
should be "df" instead of "dragonfly" as you are keeping only two formats "df" and "rdb" from the comment below.
| while true; do | ||
| {{- if eq .Values.snapshot.format "dragonfly" }} | ||
| # Keep only the last {{ .Values.snapshot.cleaner.max_count }} snapshots (composed of two files each) | ||
| ls -1t /data/dump-*.dfs | tail -n +{{ add 1 (mul .Values.snapshot.cleaner.max_count 2) }} | xargs rm -f |
Contributor
There was a problem hiding this comment.
have you tested provisioning this container locally? Just want to be sure this script works.
| - "--snapshot_cron" | ||
| - "{{ .Values.snapshot.schedule }}" | ||
| {{- if eq .Values.snapshot.format "rdb" }} | ||
| - "--nodf_snapshot_format" |
Contributor
There was a problem hiding this comment.
@romange do we have this flag? I think --df_snapshot_format=false is the correct flag to have rdb format?
Collaborator
There was a problem hiding this comment.
it's equivalent, though I am surprised that people know this notion as it is a special format for boolean flags in google flags library :) @renan how did you know? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snapshot configuration section to values.yaml with:
Add snapshot-cleaner sidecar container to pod template:
Add snapshot cron arguments to main dragonfly container
Maintains backward compatibility with existing configurations
Fixes #2824